feat: Toast for tx lifecycle #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fernandomg
reviewed
Aug 27, 2024
Member
There was a problem hiding this comment.
I'm concerned about this, why so many modifications if there were no package.json modifications at all?
| onReplaced: (replacedTxData) => (replacedTx = replacedTxData), | ||
| }) | ||
|
|
||
| if (replacedTx!) { |
Member
There was a problem hiding this comment.
If you're already checking for reaplacedTx existence, why use the non-null assertion here?
Collaborator
Author
There was a problem hiding this comment.
because it was complaining about using replacedTx before being initialized.
Collaborator
Author
There was a problem hiding this comment.
perhaps turning off the linter for that line will be more clear.
Collaborator
Author
There was a problem hiding this comment.
thank Lord! I know you'll never leave me alone microsoft/TypeScript#11498 (comment)
Co-authored-by: Fernando Greco <[email protected]>
fernandomg
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252
Description: Add toast helpers for signing and executing a tx.
A new provider was added with three independent methods allowing watching when a signature is requested, when a tx is initiated, or simply to a particular tx hash.
Type of change:
How Has This Been Tested?